test: refactor oci/helm tests for registryproviders #1113
Conversation
sdowell
force-pushed
the
local-registry-provider
branch
from
d017558
to
113f0e7
Compare
|
/assign @karlkfi |
sdowell
force-pushed
the
local-registry-provider
branch
from
113f0e7
to
ab3a222
Compare
|
/cc @nan-yu |
sdowell
force-pushed
the
local-registry-provider
branch
3 times, most recently
from
746ac74
to
9340efa
Compare
|
/retest |
| @@ -499,6 +499,28 @@ func (g *Repository) Copy(sourceDir, destDir string) error { | |||
| return err | |||
| } | |||
|
|
|||
| // UseHelmChart copies the files from the provided helm chart to the current | |||
| // repository. | |||
| func (g *Repository) UseHelmChart(chart string) error { | |||
There was a problem hiding this comment.
It is not the same repository when switching from Git to Helm. I feel like it makes more sense to copy the files when building the Helm chart.
There was a problem hiding this comment.
The idea here is that we can use the same Repository object as a primitive for creating all types of artifacts (git, oci, helm). There are tests which use the pattern of adding individual files for a helm chart and pushing it, this is just intended as a convenience function to copy over the premade helm charts from the local directory.
There was a problem hiding this comment.
I had the same confusion looking at the Repository. I expected two interfaces, one for helm and one for OCI. Having them in the same interface feels like leaking implementation details.
sdowell
force-pushed
the
local-registry-provider
branch
2 times, most recently
from
7578a1e
to
753a645
Compare
sdowell
force-pushed
the
local-registry-provider
branch
from
753a645
to
f6e4b18
Compare
This refactors the existing helm-sync/oci-sync tests which push artifacts to use the new RegistryProvider interface. This delivers a few benefits: - minimize duplicate test scaffolding - enable running these tests without GKE/AR - enable running these tests with the presubmits in kind
sdowell
force-pushed
the
local-registry-provider
branch
from
f6e4b18
to
d1df314
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karlkfi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit c0f0c59
into
GoogleContainerTools:main
This refactors the existing helm-sync/oci-sync tests which push artifacts to use the new RegistryProvider interface. This delivers a few benefits: